Java 8 Compatibility #18
Merged
+88
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Oh, that might be a problem. Hmmm. |
Contributor
Author
|
Okay, it works now, I think |
wagyourtail
reviewed
Sep 9, 2024
SpaceWalkerRS
approved these changes
Jan 31, 2026
Member
SpaceWalkerRS
left a comment
SpaceWalkerRS
left a comment
There was a problem hiding this comment.
all the static inits are not pretty but I'll fix them up later
also, this project apparently has 0 consistency when it comes to tabs vs spaces, which is fun
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, massive disclaimer: I did this in like 30 minutes flat, and I took a bunch of shortcuts (static initializer spam go brrrr), so be aware that the code probably isn't as clean as it should be.
A few major(ish) notes to take into account:
MmcPackCreator.class)tasks.compileJava.source/targetCompatiblityfor all versions of java, also sets the IDE java compat for you as well, which is nice.)I have tested the mmc pack and server and can confirm they're fully working.
I'm able to install the vanilla launcher one, but the crappy minecraft launcher doesn't work for me, so I can't test it.
If explanations are needed for anything I did, feel free to ask.